Loading…
20
Had to pick between spacing tokens or component variants for a client deadline.
Ngl I went with spacing tokens because the team was overcomplicating margins but now the modal looks off because nobody defined the inner padding rule.
2 comments
Log in to join the discussion
Log In2 Comments
the_terry5mo ago
Had the same thing happen to me last month. I used to push for component variants all the way until I hit a deadline where the team spent two days arguing over button padding instead of shipping. Now I lean toward spacing tokens first, then use variants only for extreme edge cases. How did you end up fixing the modal after that?
-1
nathang675mo ago
Totally feel you on that. Same thing happened here with a modal that had like 14 different states. Ended up just ripping out all the variants and using a single spacing token for the padding and margin. Then I added one boolean prop for the close button location and that was it. It wasn't perfect but it shipped on time and nobody complained. @the_terry you gotta pick your battles sometimes.
4